[#478] Base App migration — SDK restricted to Farcaster only#485
[#478] Base App migration — SDK restricted to Farcaster only#485realproject7 merged 2 commits intomainfrom
Conversation
Base App migrates to standard web app (April 2026). SDK actions (ready, composeCast, swapToken) now only fire in Farcaster clients. Base App and web users get standard wallet + Uniswap experience. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Clean migration — SDK gated behind platform === 'farcaster' via the existing usePlatformDetection hook. Base App swap branch correctly removed from SwapInterface. ShareToFarcaster and FarcasterMiniApp both properly guarded. The hook still detects Base App (via clientFid) so if we ever need platform-specific Base App behavior again, the detection is still there. No issues.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The SDK gating changes look correct, but the PR leaves out the required Base App identification meta tag from the issue.
Findings
- medium
src/app/layout.tsx:31still does not include the requiredother["base:app_id"] = "69c257e93c2c56b9bbd2f62a". Issue #478 calls that tag out as a concrete code change, and without it Base App cannot identify the app as registered.- File:
src/app/layout.tsx:31 - Suggestion: add the
base:app_identry to the metadataotherfield alongside the existing metadata extras.
- File:
Decision
Request changes because #478 is not complete without the base:app_id metadata tag.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The rework keeps the SDK limited to Farcaster clients and now adds the required Base App metadata tag in layout. That closes the issue requirement I previously flagged.
Findings
- None.
Decision
Approve because the base:app_id metadata is now present and the rest of the Base App migration changes remain consistent with #478.
2 participants
Summary
FarcasterMiniApp.tsx:sdk.actions.ready()now only fires whenplatform === 'farcaster'(usesusePlatformDetectionhook)ShareToFarcaster.tsx: Refactored to useusePlatformDetectioninstead of rawsdk.contextcheck; only renders in Farcaster clientsSwapInterface.tsx: Native swap viasdk.actions.swapToken()now Farcaster-only; Base App and web users get Uniswap linkAfter Base App migration (April 9, 2026), Base App operates as standard web app — no mini-app SDK needed.
Fixes #478
Operator items (separate)
base:app_idmeta tag after registrationTest plan
next build)🤖 Generated with Claude Code